Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libbeat]image.id and account.id for add_cloud_metadata EC2 #12307

Merged
merged 4 commits into from
May 28, 2019

Conversation

odacremolbap
Copy link
Contributor

Continuing @jbagel2 effort on #10914

Adding to libbeat add_cloud_metadata processor's EC2 implementation:

  • image.id
  • account.id

Note: image.id is not part of ECS, but sounds like a feasible name whether it is included or not in a future ECS reference.

Tests have been unified into a single test cased test, and account.id and image.id has been added to checks.

@odacremolbap odacremolbap requested a review from a team as a code owner May 27, 2019 18:32
@odacremolbap
Copy link
Contributor Author

cc @ruflin @webmat @kaiyan-sheng

@odacremolbap odacremolbap self-assigned this May 27, 2019
@odacremolbap odacremolbap added Team:Integrations Label for the Integrations team ecs libbeat review labels May 27, 2019
@exekias
Copy link
Contributor

exekias commented May 27, 2019

I see a few renames, this makes this a breaking change, isn't it?

@odacremolbap
Copy link
Contributor Author

afaik this is not a breaking change for now

  • 2 fields have been added at EC2 metadata
  • renames have only been introduced at docs to sync with code

@exekias exekias added the docs label May 27, 2019
@exekias
Copy link
Contributor

exekias commented May 27, 2019

sorry you are right! change LGTM, it seems it needs a mage fmt

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but it needs a changelog about the 2 added fields.

@odacremolbap
Copy link
Contributor Author

thanks for the reviews

I was silently expecting some comments regarding this file:
https://github.com/elastic/beats/blob/master/libbeat/processors/add_cloud_metadata/_meta/fields.yml

@ruflin I guess that yaml sounds like global to all cloud metadata, and shouldn't be touched until we bring those 2 fields to all other cloud providers. If I'm wrong, pls, correct me

@exekias
Copy link
Contributor

exekias commented May 28, 2019

You can definitely add them there, I see cloud.project.id is in (GCP only?). If/Once these new fields make it to ECS you can import ECS and remove them from this fields.yml

@odacremolbap odacremolbap merged commit 75c9002 into elastic:master May 28, 2019
@exekias
Copy link
Contributor

exekias commented May 29, 2019

@odacremolbap you didn't add the fields, something is wrong here?

@odacremolbap
Copy link
Contributor Author

@exekias I'll open a new issue to gather that info (image, account) from other providers, then once they are available for all (or most) add it

@exekias
Copy link
Contributor

exekias commented May 29, 2019

why not adding them now? that would mean master is missing these fields, while they may be reported in some cases. It sounds like having fields.yml in is a safer play, you can always change them when adding new providers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants